Add type hints in google/ads/googleads/interceptors #958
+984
−465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobhancockg
changed the title
bobhancockg
changed the title
bobhancockg
changed the title
BenRKarl
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
BenRKarl
added
the
kokoro:force-run
…gle/ads/googleads/interceptors` directory. Here's a list of the files I updated: - `exception_interceptor.py` - `helpers.py` - `interceptor.py` - `logging_interceptor.py` - `metadata_interceptor.py` - `response_wrappers.py` Note that `__init__.py` didn't require any changes. While adding the type hints, I also made some minor improvements to enhance the robustness and clarity of the code in a few files. This involved adding necessary imports from the `typing` module and other relevant libraries like `grpc` and `google.protobuf`. I also used TypeVars to effectively handle generic protobuf messages and continuation callables.
BenRKarl
force-pushed
the
add-type-hints-interceptors
branch
from
8d8e1a6 to
22e3ee9
Compare
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gle/ads/googleads/interceptors` directory.
Here's a list of the files I updated:
exception_interceptor.pyhelpers.pyinterceptor.pylogging_interceptor.pymetadata_interceptor.pyresponse_wrappers.pyNote that
__init__.pydidn't require any changes.While adding the type hints, I also made some minor improvements to enhance the robustness and clarity of the code in a few files. This involved adding necessary imports from the
typingmodule and other relevant libraries likegrpcandgoogle.protobuf. I also used TypeVars to effectively handle generic protobuf messages and continuation callables.