Ensure next_values(StateRead*) returns an empty set in the rare case where no next's are associated with a read #3469
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where no next's are associated with a read This is a very rare situation but it can happen during next-value optimization passes and a few other places. To simplify the implementation of these passes return an empty set in these cases. Also check that the side-table maps used to determine this are valid in this case to ensure we don't ignore corrupted procs. PiperOrigin-RevId: 840426382
copybara-service
bot
force-pushed
the
test_840426382
branch
from
c295845 to
69e0feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure next_values(StateRead*) returns an empty set in the rare case where no next's are associated with a read
This is a very rare situation but it can happen during next-value optimization passes and a few other places. To simplify the implementation of these passes return an empty set in these cases. Also check that the side-table maps used to determine this are valid in this case to ensure we don't ignore corrupted procs.