Fully remove xls/passes from dependency chain of c_api. #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include the passes as early. This makes it easier to use the c-api in some circumstances by making it simpler to avoid dependency loops. If passes and estimators are needed link in the xls/public:passes_and_estimators target. PiperOrigin-RevId: 834924569
copybara-service
bot
force-pushed
the
test_834924569
branch
from
a0e1d1e to
3afdbd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully remove xls/passes from dependency chain of c_api.
Don't include the passes as early.
This makes it easier to use the c-api in some circumstances by making it simpler to avoid dependency loops.
If passes and estimators are needed link in the xls/public:passes_and_estimators target.