Make bdd_query_engine calculate AtMostOneTrue out to 300 bits #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_812001152
branch
3 times, most recently
from
18f7991 to
69a3242
Compare
We previously wouldn't even try for more than 64 bits. By allowing more depth we get better results. This also rewrites the checker slightly to avoid creating as large of a BDD improving performance. PiperOrigin-RevId: 812934517
copybara-service
bot
force-pushed
the
test_812001152
branch
from
69a3242 to
7677774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make bdd_query_engine calculate AtMostOneTrue out to 300 bits
We previously wouldn't even try for more than 64 bits. By allowing more depth we get better results.
This also rewrites the checker slightly to avoid creating as large of a BDD improving performance.