Skip to content

Fix dependencies in xls/public #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Fix dependencies in xls/public #3121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1759c
Fix dependencies in xls/public
hzeller Sep 26, 2025
01c4896
Review comment: Add IWYU for the vast dependency.
hzeller Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xls/public/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ cc_library(
"//xls/dslx:import_data",
"//xls/dslx:interp_value",
"//xls/dslx:interp_value_from_string",
"//xls/dslx:interp_value_utils",
"//xls/dslx:parse_and_typecheck",
"//xls/dslx:replace_invocations",
"//xls/dslx:virtualizable_file_system",
Expand All @@ -235,6 +234,8 @@ cc_library(
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/types:span",
"@com_google_absl//absl/types:variant",
],
)

Expand Down
1 change: 0 additions & 1 deletion xls/public/c_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
#include "xls/jit/function_jit.h"
#include "xls/public/c_api_format_preference.h"
#include "xls/public/c_api_impl_helpers.h"
#include "xls/public/c_api_vast.h"
#include "xls/public/runtime_build_actions.h"
#include "xls/solvers/z3_ir_translator.h"
#include "xls/tools/codegen_flags.pb.h"
Expand Down
2 changes: 1 addition & 1 deletion xls/public/c_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "xls/public/c_api_dslx.h"
#include "xls/public/c_api_format_preference.h"
#include "xls/public/c_api_ir_builder.h"
#include "xls/public/c_api_vast.h"
#include "xls/public/c_api_vast.h" // IWYU pragma: export

// C API that exposes the functionality in various public headers in a way that
// C-based FFI facilities can easily wrap.
Expand Down
2 changes: 2 additions & 0 deletions xls/public/c_api_dslx.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
#include <variant>
#include <vector>

#include "absl/types/variant.h"
#include "absl/container/flat_hash_map.h"
#include "absl/types/span.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
Expand Down
Loading