-
Notifications
You must be signed in to change notification settings - Fork 213
Add force_implicit_token_calling_convention flag to dslx to ir converter #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_implicit_token_calling_convention flag to dslx to ir converter #3076
Conversation
| GetModuleMemberTypeName(*member.value()), node->identifier(), | ||
| node->span().ToString(file_table()))); | ||
| }}, | ||
| Visitor{[&](Function* f) { return DefAlias(f, /*to=*/node); }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this change? hard to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an auto formatter artifact and I reverted it.
|
The CI failure does not seem to be related. |
|
@lsrcz can you confirm which version of xlsynth is compatible with this change? |
|
@proppy I think it is compatible with xlsynth's rust crate since v0.6.0. |
This pull request adds a flag to the DSLX-to-IR converter that forces all functions to use the implicit-token calling convention.
We need this to enable IR transformations that insert assertions into existing programs, which requires converting the function to the implicit-token convention.
Previously, this was impossible because the activation bit could not be inferred from the converted IR alone.
To support this behavior, we introduce a new flag that instructs the converter to generate implicit tokens for all functions.
This includes a breaking change to the C API to include the flag.