Clean up temp dirs after validation #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete residual xsd files after parsing the XSD schemas. Before, these files were left on the disk because the Java built-in deleteOnExit does not delete non-empty directories. This change also simlifies the code by removing the ResourceManager class and parsing all the schemas on initialization, deleting the temp files as soon as possible.
| } catch (SAXException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
It can throw other exception types, why are we catching this particular one? Could we leave as it was, as we were relying on that to identify whether the schema couldn't be created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete residual xsd files after parsing the XSD schemas. Before, these files were left on the disk because the Java built-in deleteOnExit does not delete non-empty directories.
This change also simlifies the code by removing the ResourceManager class and parsing all the schemas on initialization, deleting the temp files as soon as possible.