-
Notifications
You must be signed in to change notification settings - Fork 43
Add -force argument for ungraceful disconnect #2
base: master
Are you sure you want to change the base?
Conversation
- Update to python 3 - Fix FD regex - Print shutdown() prior executing
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@caruccio looks like the Google bot is confused because I'm building on top of your PR, even you did consent. |
|
So what can we do now? Maybe a fresh new pr will do the job? Fell free to handle at your will. |
|
Hi guys, thank you for your contributions! FYI, I'm no longer at Google and am no longer maintaining this codebase. |
I found it useful to test a less graceful disconnection than what
shutdown()produces.This PR adds a
-forceargument which callsclose()instead. This results in aBad file descriptor (9)error, although ideally I'd like to it produce aConnection reset by peer (104)error.Builds on top of Python 3 support in #1.