Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Conversation

@Sjors
Copy link

@Sjors Sjors commented Oct 25, 2019

I found it useful to test a less graceful disconnection than what shutdown() produces.

This PR adds a -force argument which calls close() instead. This results in a Bad file descriptor (9) error, although ideally I'd like to it produce a Connection reset by peer (104) error.

Builds on top of Python 3 support in #1.

caruccio and others added 2 commits April 18, 2018 11:31
- Update to python 3
- Fix FD regex
- Print shutdown() prior executing
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Sjors
Copy link
Author

Sjors commented Oct 25, 2019

@googlebot I signed it!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@Sjors
Copy link
Author

Sjors commented Oct 25, 2019

@caruccio looks like the Google bot is confused because I'm building on top of your PR, even you did consent.

@caruccio
Copy link

So what can we do now? Maybe a fresh new pr will do the job? Fell free to handle at your will.

@Sjors
Copy link
Author

Sjors commented Oct 25, 2019

@caruccio the bot says you just need to say @googlebot I consent.. Alternatively if the maintainer (@geffner) merges your PR, I can rebase on master.

@geffner
Copy link
Contributor

geffner commented Oct 25, 2019

Hi guys, thank you for your contributions! FYI, I'm no longer at Google and am no longer maintaining this codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants