tcmalloc rust bindings #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayakasadev
commented
Mar 26, 2025
tcmalloc/BUILD
Outdated
| load("//tcmalloc:copts.bzl", "TCMALLOC_DEFAULT_COPTS") | ||
| load("//tcmalloc:variants.bzl", "create_tcmalloc_benchmark", "create_tcmalloc_libraries", "create_tcmalloc_testsuite") | ||
|
|
||
| package(default_visibility = ["//visibility:private"]) | ||
|
|
||
| licenses(["notice"]) | ||
|
|
||
| exports_files(["LICENSE"]) | ||
| exports_files(["LICENSE", "tcmalloc.h"]) |
There was a problem hiding this comment.
export of tcmalloc.h required to generate rust bindings.
jayakasadev
commented
Mar 26, 2025
Comment on lines
+31
to
+42
| bool_flag( | ||
| name = "alwayslink", | ||
| build_setting_default = True, | ||
| ) | ||
|
|
||
| config_setting( | ||
| name = "unlinked", | ||
| flag_values = { | ||
| ":alwayslink": "false", | ||
| }, | ||
| visibility = ["//visibility:public"], | ||
| ) |
There was a problem hiding this comment.
alwayslink generates a .lo file which is not recognized by rustc. This flags allws users to disable it for rust specifically.
jayakasadev
commented
Mar 26, 2025
jayakasadev
force-pushed
the
rust_client
branch
2 times, most recently
from
61ccfdb to
ed11cc4
Compare
jayakasadev
force-pushed
the
rust_client
branch
6 times, most recently
from
a78505e to
f9e8f49
Compare
jayakasadev
force-pushed
the
rust_client
branch
from
f9e8f49 to
fc939a7
Compare
jayakasadev
force-pushed
the
rust_client
branch
from
111af67 to
27b9533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
tcmalloc_rswhich generates necessary rust bindings and surfaces a lib for rust users to adopttcmalloc.