-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS entry point for block editor. #9985
Add JS entry point for block editor. #9985
Conversation
Build files for 089868f have been deleted. |
Size Change: +477 B (+0.02%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, this is most of the way there. It could use a few tweaks, and I've left a couple of questions. Please take a look.
tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php
Outdated
Show resolved
Hide resolved
tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php
Outdated
Show resolved
Hide resolved
tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php
Outdated
Show resolved
Hide resolved
webpack/common.js
Outdated
exports.gutenbergExternals = gutenbergExternals; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well revert this change to keep the exports
addition next to the constant definition as it is now...
tests/phpunit/integration/Modules/Reader_Revenue_ManagerTest.php
Outdated
Show resolved
Hide resolved
Thanks for reviewing the PR and adding your valuable suggestions @techanvil. I've made the suggested changes in PR and assigned it to you to review those. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, that's great. LGTM!
✅
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist