Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter (not set) cities from Audience Tiles. #9984

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Jan 7, 2025

Summary

Addresses issue:

Relevant technical choices

Additionally I removed the label props in related VRTs as these triggered the new no-storybook-scenario-label rule.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jan 7, 2025

Build files for f14c1a0 are ready:

Copy link

github-actions bot commented Jan 7, 2025

Size Change: -38 B (0%)

Total Size: 1.99 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 24 kB -2 B (-0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.1 kB -36 B (-0.07%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.8 kB -1 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.17 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB +3 B (+0.13%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 28.2 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.4 kB -24 B (-0.03%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 166 kB +41 B (+0.02%)
./dist/assets/js/googlesitekit-metric-selection-********************.js 52 kB -9 B (-0.02%)
./dist/assets/js/googlesitekit-modules-********************.js 22.4 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 35.8 kB -8 B (-0.02%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 119 kB -6 B (-0.01%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 191 kB -54 B (-0.03%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 69.1 kB -19 B (-0.03%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.4 kB +9 B (+0.03%)
./dist/assets/js/googlesitekit-notifications-********************.js 37 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-settings-********************.js 127 kB +47 B (+0.04%)
./dist/assets/js/googlesitekit-splash-********************.js 68.7 kB -3 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 43.9 kB -2 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 324 kB +5 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 102 kB +20 B (+0.02%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 63.2 kB +4 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 62.2 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.44 kB
./dist/assets/js/33-********************.js 2.76 kB
./dist/assets/js/34-********************.js 2.25 kB
./dist/assets/js/35-********************.js 3.64 kB
./dist/assets/js/36-********************.js 936 B
./dist/assets/js/37-********************.js 892 B
./dist/assets/js/38-********************.js 1.61 kB
./dist/assets/js/39-********************.js 1.57 kB
./dist/assets/js/40-********************.js 1.61 kB
./dist/assets/js/41-********************.js 1.59 kB
./dist/assets/js/42-********************.js 1.83 kB
./dist/assets/js/43-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.97 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 31.2 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/runtime-********************.js 1.4 kB

compressed-size-action

Copy link
Collaborator

@ankitrox ankitrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Moving this to MR.

Copy link
Collaborator

@ankitrox ankitrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbowler Sorry, it looks like the tests for assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/index.test.js are failing.

Can you please look into these and fix them?

Thanks

@benbowler
Copy link
Collaborator Author

Thanks @ankitrox, fixed the test by updating the report query to match and updating relevant snapshots. Once the checks are passing I'll send back to you to review.

@ankitrox
Copy link
Collaborator

LGTM 💯
Moving this to MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants