-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter (not set) cities from Audience Tiles. #9984
base: develop
Are you sure you want to change the base?
Filter (not set) cities from Audience Tiles. #9984
Conversation
Build files for f14c1a0 are ready:
|
Size Change: -38 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 Moving this to MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbowler Sorry, it looks like the tests for assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/index.test.js
are failing.
Can you please look into these and fix them?
Thanks
…ide-not-set-audience-segmentation.
Thanks @ankitrox, fixed the test by updating the report query to match and updating relevant snapshots. Once the checks are passing I'll send back to you to review. |
LGTM 💯 |
Summary
Addresses issue:
Relevant technical choices
Additionally I removed the label props in related VRTs as these triggered the new
no-storybook-scenario-label
rule.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist