Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue / 9864 Update Icons to Inherit Color #9950

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

10upsimon
Copy link
Collaborator

@10upsimon 10upsimon commented Jan 2, 2025

Summary

Addresses issue:

Relevant technical choices

  • Updated all SVG files, removed fill and stroke color definitions (where applicable) and changed to currentColor.
  • Updated CSS rules across the codebase and correctly defined color properties in order for SVG icons to inherit the correct color.
  • Explicitly updated the VRT reference images for SubtleNotification custom icon story, as the incorrect shade of green was being used prior. The icon now correctly inherits the same green color as defined for the banner itself.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@10upsimon 10upsimon marked this pull request as ready for review January 6, 2025 12:52
Copy link

github-actions bot commented Jan 6, 2025

Build files for 9dee87e have been deleted.

@eugene-manuilov eugene-manuilov merged commit f0635b8 into develop Jan 6, 2025
31 of 35 checks passed
@eugene-manuilov eugene-manuilov deleted the issue/9864-update-icons-to-inherit-color branch January 6, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants