Update getDateRangeIndex logic. #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 95f21a1 have been deleted. |
|
Size Change: +22 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
tofumatt
requested changes
Jan 29, 2025
There was a problem hiding this comment.
The code here looks good, but the QA Brief is a bit unclear to me 😅
Note: It should work across all date ranges, the traffic source can be empty, having
-as content, if there is no data at all, or if the difference is-100%, which happens in recent date range bellow 90 days, depends on the time this issue is in QA. This is valid as current date range would not return data for traffic source - empty values, while date range in the past we are comparing it agains, had some traffic source for the data.
I'm not quite clear on what this QA note means.
There's also a note in the QA brief mentioning "You can use brainiest website for the test, since it has data for conversion events"—what is this site? 😅
Can you clarify the exact steps to test this in the QA brief? I think it's a bit unclear in terms of what the "notes" section is adding to the QA brief. 🤔
|
Thanks @tofumatt I simplified the QAB
This is a test website we were using for testing ACR data during the epic development, QA is familiar with it. But I expanded it to the full URL now |
tofumatt
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist