Improve dismissItem behaviour in SiwG.
#10095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 4f9637c have been deleted. |
|
Size Change: +123 B (+0.01%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
4 tasks
zutigrm
reviewed
Jan 29, 2025
| @@ -119,6 +122,7 @@ SettingsNotice.propTypes = { | |||
| LearnMore: PropTypes.elementType, | |||
| CTA: PropTypes.elementType, | |||
| OuterCTA: PropTypes.elementType, | |||
| dismiss: PropTypes.oneOfType( [ PropTypes.string, PropTypes.bool ] ), | |||
There was a problem hiding this comment.
Wondering why are we allowing dismiss to be a boolean as well? As the only intended type for this prop is supposed to be the string, and default value is already set to the empty string if prop is not passed - the logic won't work with boolean value anyway (if we pass true for example, no dismissal will happen, but we will not get error until we attempt to dismiss it when invariant in the action will throw an error)
There was a problem hiding this comment.
You are correct! This was here before when I was testing things out, it can/should just be string now. I've updated it, thanks 😀
|
Thanks @tofumatt LGTM |
eugene-manuilov
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist