Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jest-puppeteer and puppeteer package versions. #10020

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Jan 14, 2025

Summary

Addresses issue:

Relevant technical choices

In this PR, working from the base of the E2E refactor to a distinct folder, I'm working through puppeteer versions to see how far we can upgrade without the majority of tests failing.

It's important to note E2E tests are unreliable at best in develop at the moment, so my mark for an effective package version upgrade is the workflow running with the majority of E2E tests passing, as part of this issue (or in #8229) the E2E tests should be audited for reliability, perhaps upgrading these packages would offer more modern tools to make tests more reliable.

The most I was able to update the versions to was the following without breaking the suite:

"jest-puppeteer": "^6.2.0",
"puppeteer": "^11.0.0"

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler changed the base branch from infrastructure/5862-puppeteer-upgrade to develop January 14, 2025 14:26
@benbowler benbowler force-pushed the infrastructure/5862-puppeteer-upgrade-package-versions branch from 5cbc6f7 to e9856a9 Compare January 14, 2025 14:32
Copy link

github-actions bot commented Jan 14, 2025

Build files for 32871f4 are ready:

@benbowler benbowler mentioned this pull request Jan 14, 2025
3 tasks
@benbowler benbowler changed the title Test upgrade to jest-puppeteer 5.0.4. Upgrade to jest-puppeteer and puppeteer package versions. Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant