-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jest-puppeteer and puppeteer package versions. #10020
Open
benbowler
wants to merge
15
commits into
develop
Choose a base branch
from
infrastructure/5862-puppeteer-upgrade-package-versions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to jest-puppeteer and puppeteer package versions. #10020
benbowler
wants to merge
15
commits into
develop
from
infrastructure/5862-puppeteer-upgrade-package-versions
+5,148
−774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbowler
changed the base branch from
infrastructure/5862-puppeteer-upgrade
to
develop
January 14, 2025 14:26
…ble versions of packages.
benbowler
force-pushed
the
infrastructure/5862-puppeteer-upgrade-package-versions
branch
from
January 14, 2025 14:32
5cbc6f7
to
e9856a9
Compare
Build files for 32871f4 are ready:
|
benbowler
changed the title
Test upgrade to jest-puppeteer 5.0.4.
Upgrade to jest-puppeteer and puppeteer package versions.
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
In this PR, working from the base of the E2E refactor to a distinct folder, I'm working through puppeteer versions to see how far we can upgrade without the majority of tests failing.
It's important to note E2E tests are unreliable at best in develop at the moment, so my mark for an effective package version upgrade is the workflow running with the majority of E2E tests passing, as part of this issue (or in #8229) the E2E tests should be audited for reliability, perhaps upgrading these packages would offer more modern tools to make tests more reliable.
The most I was able to update the versions to was the following without breaking the suite:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist