Merge pull request #7667 from google/fix/7577-visits-per-visitor-kmw-…

…metric-change Fix / 7577 Visits Per Visitor KMW Metric Change
google · Oct 5, 2023 · e713eb5 · e713eb5
2 parents 0e58d82 + 8e743aa
commit e713eb5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/assets/js/modules/analytics-4/components/widgets/VisitsPerVisitorWidget.js b/assets/js/modules/analytics-4/components/widgets/VisitsPerVisitorWidget.js
@@ -53,7 +53,7 @@ function VisitsPerVisitorWidget( { Widget } ) {
 
 	const reportOptions = {
 		...dates,
-		metrics: [ { name: 'sessionsPerUser' }, { name: 'activeUsers' } ],
+		metrics: [ { name: 'sessionsPerUser' }, { name: 'sessions' } ],
 	};
 
 	const report = useInViewSelect( ( select ) =>
@@ -74,7 +74,7 @@ function VisitsPerVisitorWidget( { Widget } ) {
 			)
 	);
 
-	const { rows = [], totals = [] } = report || {};
+	const { rows = [] } = report || {};
 
 	const makeFind = ( dateRange ) => ( row ) =>
 		get( row, 'dimensionValues.0.value' ) === dateRange;
@@ -87,8 +87,10 @@ function VisitsPerVisitorWidget( { Widget } ) {
 		rows.find( makeFind( 'date_range_1' ) )?.metricValues?.[ 0 ]?.value ||
 		0;
 
-	const currentTotalVisitors =
-		Number( totals[ 0 ]?.metricValues?.[ 1 ]?.value ) || 0;
+	const currentTotalSessions =
+		Number(
+			rows.find( makeFind( 'date_range_0' ) )?.metricValues?.[ 1 ]?.value
+		) || 0;
 
 	return (
 		<MetricTileNumeric
@@ -98,7 +100,7 @@ function VisitsPerVisitorWidget( { Widget } ) {
 			subText={ sprintf(
 				/* translators: %d: Number of total visits to the site. */
 				__( '%s total visits', 'google-site-kit' ),
-				numFmt( currentTotalVisitors, { style: 'decimal' } )
+				numFmt( currentTotalSessions, { style: 'decimal' } )
 			) }
 			previousValue={ Number( previousVisitsPerVisitor ) }
 			currentValue={ Number( currentVisitsPerVisitor ) }

diff --git a/assets/js/modules/analytics-4/components/widgets/VisitsPerVisitorWidget.stories.js b/assets/js/modules/analytics-4/components/widgets/VisitsPerVisitorWidget.stories.js
@@ -47,7 +47,7 @@ const reportOptions = {
 			name: 'sessionsPerUser',
 		},
 		{
-			name: 'activeUsers',
+			name: 'sessions',
 		},
 	],
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,7 +47,7 @@ const reportOptions = { @@
     			name: 'sessionsPerUser',
     		},
     		{
-    			name: 'activeUsers',
+    			name: 'sessions',
     		},
     	],
     };
@@ Expand Down @@