Skip to content

Commit

Permalink
Rename event_value to value in other tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
@aaemnnosttv
aaemnnosttv committed Nov 5, 2020
1 parent fac29eb commit c9521f5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions assets/js/components/data/index.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe( 'dataAPI', () => {
expect( eventName ).toEqual( 'GET:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
}
} );
} );
Expand All @@ -90,7 +90,7 @@ describe( 'dataAPI', () => {
expect( eventName ).toEqual( 'POST:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
}
} );
} );
Expand Down Expand Up @@ -166,7 +166,7 @@ describe( 'dataAPI', () => {
expect( eventName ).toEqual( 'POST:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error, reason: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
} );

it( 'should call trackEvent for each error in combinedGet with multiple errors', async () => {
Expand Down Expand Up @@ -207,13 +207,13 @@ describe( 'dataAPI', () => {
expect( eventName ).toEqual( 'POST:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error, reason: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
[ event, eventName, eventData ] = dataLayerPushSpy.mock.calls[ 1 ][ 0 ];
expect( event ).toEqual( 'event' );
expect( eventName ).toEqual( 'POST:test-type/analytics/data/test-datapoint-3' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Unknown error (code: unknown_error, reason: unknown_error)' );
expect( eventData.event_value ).toEqual( 503 );
expect( eventData.value ).toEqual( 503 );
} );
} );
} );
4 changes: 2 additions & 2 deletions assets/js/googlesitekit/api/index.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe( 'googlesitekit.api', () => {
expect( eventName ).toEqual( 'GET:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
}
} );
} );
Expand Down Expand Up @@ -491,7 +491,7 @@ describe( 'googlesitekit.api', () => {
expect( eventName ).toEqual( 'POST:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'Internal server error (code: internal_server_error)' );
expect( eventData.event_value ).toEqual( 500 );
expect( eventData.value ).toEqual( 500 );
}
} );
} );
Expand Down
6 changes: 3 additions & 3 deletions assets/js/util/api.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe( 'trackAPIError', () => {
expect( eventName ).toEqual( 'test-method:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'test-error-message (code: test-error-code, reason: test-error-reason)' );
expect( eventData.event_value ).toEqual( 'test-error-code' );
expect( eventData.value ).toEqual( 'test-error-code' );
} );

it( 'tracks API error message & code with no reason', () => {
Expand All @@ -74,7 +74,7 @@ describe( 'trackAPIError', () => {
expect( eventName ).toEqual( 'test-method:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'test-error-message (code: test-error-code)' );
expect( eventData.event_value ).toEqual( 'test-error-code' );
expect( eventData.value ).toEqual( 'test-error-code' );
} );

it( 'tracks API error message & code with no data', () => {
Expand All @@ -94,7 +94,7 @@ describe( 'trackAPIError', () => {
expect( eventName ).toEqual( 'test-method:test-type/test-identifier/data/test-datapoint' );
expect( eventData.event_category ).toEqual( 'api_error' );
expect( eventData.event_label ).toEqual( 'test-error-message (code: test-error-code)' );
expect( eventData.event_value ).toEqual( 'test-error-code' );
expect( eventData.value ).toEqual( 'test-error-code' );
} );

it( "doesn't track excluded error codes", () => {
Expand Down

0 comments on commit c9521f5

Please sign in to comment.