Rename RRM dismissal key to be legacy.

google · Jan 10, 2025 · 0889c1b · 0889c1b
1 parent 2406bda
commit 0889c1b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...es/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.test.js b/...es/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.test.js
@@ -40,7 +40,7 @@ import { CORE_MODULES } from '../../../../googlesitekit/modules/datastore/consta
 import {
 	ERROR_CODE_NON_HTTPS_SITE,
 	READER_REVENUE_MANAGER_MODULE_SLUG,
-	READER_REVENUE_MANAGER_SETUP_BANNER_DISMISSED_KEY,
+	LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY,
 } from '../../datastore/constants';
 import { VIEW_CONTEXT_MAIN_DASHBOARD } from '../../../../googlesitekit/constants';
 import useActivateModuleCallback from '../../../../hooks/useActivateModuleCallback';
@@ -373,7 +373,7 @@ describe( 'ReaderRevenueManagerSetupCTABanner', () => {
 
 		it( 'is not active when the banner was dismissed with the legacy dismissal key', async () => {
 			registry.dispatch( CORE_USER ).receiveGetDismissedPrompts( {
-				[ READER_REVENUE_MANAGER_SETUP_BANNER_DISMISSED_KEY ]: {
+				[ LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY ]: {
 					expires: Date.now() / 1000 + WEEK_IN_SECONDS,
 					count: 1,
 				},

diff --git a/assets/js/modules/reader-revenue-manager/datastore/constants.js b/assets/js/modules/reader-revenue-manager/datastore/constants.js
@@ -32,7 +32,7 @@ export const PUBLICATION_ONBOARDING_STATES = {
 export const UI_KEY_READER_REVENUE_MANAGER_SHOW_PUBLICATION_APPROVED_NOTIFICATION =
 	'READER_REVENUE_MANAGER_SHOW_PUBLICATION_APPROVED_NOTIFICATION';
 
-export const READER_REVENUE_MANAGER_SETUP_BANNER_DISMISSED_KEY =
+export const LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY =
 	'rrm_module_setup_banner_dismissed_key';
 
 export const READER_REVENUE_MANAGER_SETUP_FORM =

diff --git a/assets/js/modules/reader-revenue-manager/index.js b/assets/js/modules/reader-revenue-manager/index.js
@@ -30,7 +30,7 @@ import {
 	MODULES_READER_REVENUE_MANAGER,
 	ERROR_CODE_NON_HTTPS_SITE,
 	READER_REVENUE_MANAGER_MODULE_SLUG,
-	READER_REVENUE_MANAGER_SETUP_BANNER_DISMISSED_KEY,
+	LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY,
 } from './datastore/constants';
 import { SetupMain } from './components/setup';
 import { SettingsEdit, SettingsView } from './components/settings';
@@ -97,7 +97,7 @@ export const NOTIFICATIONS = {
 			// to use the `notification ID` as the dismissal key, is dismissed.
 			await resolveSelect( CORE_USER ).getDismissedPrompts();
 			const isDismissed = select( CORE_USER ).isPromptDismissed(
-				READER_REVENUE_MANAGER_SETUP_BANNER_DISMISSED_KEY
+				LEGACY_RRM_SETUP_BANNER_DISMISSED_KEY
 			);
 
 			const canActivateRRMModule = await resolveSelect(