Add tests to ensure this remains unchanged when {Add,Sub,Mul,FusedMulAdd}InPlace fail
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_850507664
branch
from
06289e0 to
e86df2e
Compare
copybara-service
bot
changed the title
this unchanged when {Add,Sub,Mul,FusedMulAdd}InPlace failthis remains unchanged when {Add,Sub,Mul,FusedMulAdd}InPlace fail
…ulAdd}InPlace fail This invariant holds because a valid RnsPolynomial will always have coefficient vectors of the same length, and batch operations only fail on length mismatch. PiperOrigin-RevId: 850507664
copybara-service
bot
force-pushed
the
test_850507664
branch
from
e86df2e to
a482b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to ensure
thisremains unchanged when {Add,Sub,Mul,FusedMulAdd}InPlace failThis invariant holds because a valid RnsPolynomial will always have coefficient vectors
of the same length, and batch operations only fail on length mismatch.