Keep packed vector configs order stable by using BTreeMap instead of HashMap #70
+28
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852437085
branch
3 times, most recently
from
efcd208 to
e7cfe0b
Compare
…HashMap Encryption packs messages in the order of packed vector configs, and decryption assumes it's the same. HashMap does not guarantee that the order remains stable across executions. PiperOrigin-RevId: 853341985
copybara-service
bot
force-pushed
the
test_852437085
branch
from
e7cfe0b to
83c763f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep packed vector configs order stable by using BTreeMap instead of HashMap
Encryption packs messages in the order of packed vector configs, and decryption assumes it's the same.
HashMap does not guarantee that the order remains stable across executions.