SD image requests - fixes for error handling, add health check and al… #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narflex
reviewed
Nov 27, 2025
| LINEUP_SD_ACCOUNT_BLOCKED=Schedules Direct Account Blocked | ||
| LINEUP_SD_ACCOUNT_BLOCKED_MSG=The Schedules Direct account is blocked. Please contact Schedules Direct to resolve this issue. | ||
| SOFTWARE_UPDATE_AVAILABLE_MSG=Software update available | ||
| SOFTWARE_UPDATE_AVAILABLE=New version available on Github: "{0}". Go to: "{1}" to check it out. |
Collaborator
There was a problem hiding this comment.
There is a prior definition of SOFTWARE_UPDATE_AVAILABLE in this file which should be removed. The definitions of SOFTWARE_UPDATE_AVAILABLE and SOFTWARE_UPDATE_AVAILABLE_MSG should also be swapped for consistency (here and in the code).
java/sage/msg/SystemMessage.java
Outdated
| java.util.Properties props = new java.util.Properties(); | ||
| props.setProperty("Version", version); | ||
| props.setProperty("Location", location); | ||
| String versionMsg = "New version on github: " + version + " go to:" + location; |
Collaborator
There was a problem hiding this comment.
You can remove this line now since version msg is no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ert if blocked