Skip to content

Fix daily notification of new version. Should only notify once when … #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Narflex merged 1 commit into from
Jun 18, 2025
Merged

Fix daily notification of new version. Should only notify once when … #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Next

## Version 9.2.14 (2025-06-16)
* Fix daily notification of new version. Should only notify once when new version is available

## Version 9.2.13 (2025-05-23)
* More fixes for placeshifter on windows (added consolewin registry optional logging to match client)

Expand Down
2 changes: 1 addition & 1 deletion java/sage/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class Version
{
public static final byte MAJOR_VERSION = 9;
public static final byte MINOR_VERSION = 2;
public static final byte MICRO_VERSION = 13;
public static final byte MICRO_VERSION = 14;

public static final String VERSION = MAJOR_VERSION + "." + MINOR_VERSION + "." + MICRO_VERSION + "." + SageConstants.BUILD_VERSION;

Expand Down
17 changes: 14 additions & 3 deletions java/sage/Wizard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ private Index getIndex(byte tableCode, byte indexCode)
static final String CLEAR_WATCHED = "clearwatched";
private static final String NOSHOW_ID = "noshow_id";
private static final String LAST_MAINTENANCE = "last_maintenance";
private static final String LAST_VER_NOTIFY = "last_ver_notify";
private static final String NODATA_MAX_LEN = "nodata_max_len";
private static final String NODATA_DUR_FOR_MAXRULE = "nodata_dur_for_maxrule";

Expand Down Expand Up @@ -7254,9 +7255,19 @@ public boolean checkForUpdate(){

if(compareVersion(latestVersion, currentVersion)==1){
if (Sage.DBG) System.out.println("checkForUpdate: currentVersion:" + currentVersion + " latestVersion:" + latestVersion + " New version is available");
//add notification of new version
sage.msg.MsgManager.postMessage(sage.msg.SystemMessage.createVersionUpdateMsg(latestVersion, url.toString()));
return true;
//check if we have already notified of this new version

String lastNotifyVer = Sage.get(prefsRoot + LAST_VER_NOTIFY, "");
if (lastNotifyVer.length() == 0 || !latestVersion.equals(lastNotifyVer)){
//add notification of new version
sage.msg.MsgManager.postMessage(sage.msg.SystemMessage.createVersionUpdateMsg(latestVersion, url.toString()));
Sage.put(prefsRoot + LAST_VER_NOTIFY, latestVersion);
return true;
}else{
if (Sage.DBG) System.out.println("checkForUpdate: currentVersion:" + currentVersion + " latestVersion:" + latestVersion + " Notification already created. Skipping");
return false;
}

}
if (Sage.DBG) System.out.println("checkForUpdate: currentVersion:" + currentVersion + " latestVersion:" + latestVersion + " No new version is available");
return false;
Expand Down