Placeshifter fix for windows #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narflex
requested changes
May 18, 2025
Narflex
reviewed
May 18, 2025
Collaborator
Narflex
left a comment
Narflex
left a comment
There was a problem hiding this comment.
If you want me to be less critical on things, let me know. :) I appreciate the contributions...and now that I'm about to retire, have more time to do more thorough code reviews for the few patches that come in....so they can be a little more picky.
…to file [ci release]
Contributor
Author
|
Please continue to provide feedback...its a great way to learn. I should have caught some of those (most) myself! Good luck in retirement. Mine has kept me very busy but it's been great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer clear fix which was failing on windows placeshifter due to jdk changes