ci: add sanitizer workflows #461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmr
reviewed
Oct 8, 2025
| - name: Configure sanitizer environment | ||
| run: | | ||
| if command -v llvm-symbolizer >/dev/null 2>&1; then | ||
| echo LLVM_SYMBOLIZER_PATH=$(command -v llvm-symbolizer) >> $GITHUB_ENV |
|
|
||
| - uses: zacharyburnett/setup-abseil-cpp@713a4383f10b05948a6d9d4906056063c8da1168 # Not a release, but has #423 fix. | ||
| env: | ||
| CC: clang |
There was a problem hiding this comment.
Do these need to be set again? I'm not very familiar with github actions.
smcallis
reviewed
Oct 8, 2025
| include: | ||
| - name: asan | ||
| sanitizer: address | ||
| compile_flags: "-fsanitize=address -fno-omit-frame-pointer" |
There was a problem hiding this comment.
WDYT about -fsanitize=address,undefined here? Merge the UBSAN and ASAN together? UBSAN is the one that catches a lot of errors during testing for me.
There was a problem hiding this comment.
I think -fsanitize=address,undefined,local-bounds,nullability looks good.
https://github.com/google/s2geometry/actions/runs/18301785002/job/53309264384?pr=461#step:3:143
jmr
reviewed
Oct 22, 2025
| include: | ||
| - name: asan | ||
| sanitizer: address | ||
| compile_flags: "-fsanitize=address -fno-omit-frame-pointer" |
There was a problem hiding this comment.
This is not quoted correctly when expanded:
https://github.com/google/s2geometry/actions/runs/18301785002/job/53309264384?pr=461#step:3:143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Issue #457 covers the lack of sanitizer coverage. Running ASan/MSan/TSan in CI helps catch undefined behavior early without altering the main build pipeline.
Fixes #457