Skip to content

re2: add compiled_ check to AllMatches and AllPotentials #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkLee131 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

re2: add compiled_ check to AllMatches and AllPotentials #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions re2/filtered_re2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ int FilteredRE2::FirstMatch(absl::string_view text,
bool FilteredRE2::AllMatches(absl::string_view text,
const std::vector<int>& atoms,
std::vector<int>* matching_regexps) const {
if (!compiled_) {
ABSL_LOG(DFATAL) << "AllMatches called before Compile.";
matching_regexps->clear();
return false;
}
matching_regexps->clear();
std::vector<int> regexps;
prefilter_tree_->RegexpsGivenStrings(atoms, &regexps);
Expand All @@ -123,6 +128,11 @@ bool FilteredRE2::AllMatches(absl::string_view text,

void FilteredRE2::AllPotentials(const std::vector<int>& atoms,
std::vector<int>* potential_regexps) const {
if (!compiled_) {
ABSL_LOG(DFATAL) << "AllPotentials called before Compile.";
potential_regexps->clear();
return;
}
prefilter_tree_->RegexpsGivenStrings(atoms, potential_regexps);
}

Expand Down