re2: fix mark deduplication flag in Workq::mark()#612
Open
MarkLee131 wants to merge 1 commit intogoogle:mainfrom
Open
re2: fix mark deduplication flag in Workq::mark()#612MarkLee131 wants to merge 1 commit intogoogle:mainfrom
MarkLee131 wants to merge 1 commit intogoogle:mainfrom
Conversation
Workq::mark() sets last_was_mark_ to false after inserting a mark. It should set it to true so that a subsequent call to mark() without an intervening insert() is correctly deduplicated. This is a correctness bug that affects longest-match mode. Duplicate marks can cause incorrect match priority ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #611:
Workq::mark() sets last_was_mark_ to false after inserting a mark. It should set it to true so that a subsequent call to mark() without an intervening insert() is correctly deduplicated.
This is a correctness bug that affects longest-match mode. Duplicate marks can cause incorrect match priority ordering.