dfa: make slow-bail progress tracking direction-aware in reverse scans#609
Open
jmestwa-coder wants to merge 1 commit intogoogle:mainfrom
Open
dfa: make slow-bail progress tracking direction-aware in reverse scans#609jmestwa-coder wants to merge 1 commit intogoogle:mainfrom
jmestwa-coder wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes progress tracking in the DFA slow-bail path for reverse scans.
The existing logic measures progress as p - resetp, which is correct for forward traversal but not for reverse traversal, where p moves backward. In that case, the difference becomes negative after progress and can turn into a large unsigned value when cast to size_t, preventing the intended bailout check from triggering.