-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual analogue scale (Android, Server) #1536
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission! We would love to have this new input element.
We have to check with existing users to see if they can move to SDK 16 minimum. Some do a lot of research in India where 4.0 was still fairly prevalent not too long ago.
Paco/AndroidManifest.xml
Outdated
@@ -365,5 +365,5 @@ | |||
<uses-permission android:name="android.permission.READ_CALENDAR" /> | |||
|
|||
<uses-feature android:name="android.hardware.camera" android:required="false"/> | |||
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="22"></uses-sdk> | |||
<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="22"></uses-sdk> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something in this change that requires sdk 16? If not, please revert so we are supporting back to Android 4.0.
5674621
to
07ef8aa
Compare
The SeekBar.getThumb()-function needed API 16. |
Hi @JodliDev this is very cool. Is there any code to show the scale in the Preview (server side). All I can see is the question text, but nothing under it. |
…), taken from google#1536 but modified, bumping Android version to API level 16
In case you are interested, I added a default material slider to the server preview here: josmas@9c2b33b Also fixed the services.js conflict but I bumped to API 16 and set limits to 0-100 for now, cause it is what I need. Happy to back port or add functionality if there's a need for it. |
Adds the option to create a Visual Analogue Scale for android as an Input-Element
(needs min-APIVersion 16)