Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guided remediation): remove --relock-cmd flag #1517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelkedar
Copy link
Member

@michaelkedar michaelkedar commented Jan 21, 2025

--relock-cmd let you override the npm install command with an arbitrary command to regenerate the package-lock.json after doing a relax.
We probably don't want to have that option in osv-scalibr when we migrate this there, so I've removed it now before the v2 release of osv-scanner.

If someone actually needs this, they can run the command themselves outside of osv-scanner.

@michaelkedar michaelkedar changed the title misc(guided remediation): remove --relock-cmd flag fix(guided remediation): remove --relock-cmd flag Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.00%. Comparing base (33c8a7a) to head (a3f9b48).

Files with missing lines Patch % Lines
cmd/osv-scanner/fix/state-relock-result.go 0.00% 2 Missing ⚠️
cmd/osv-scanner/fix/noninteractive.go 0.00% 0 Missing and 1 partial ⚠️
cmd/osv-scanner/fix/regen_lockfile.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1517      +/-   ##
==========================================
+ Coverage   68.98%   69.00%   +0.01%     
==========================================
  Files         197      197              
  Lines       18800    18791       -9     
==========================================
- Hits        12970    12966       -4     
+ Misses       5127     5121       -6     
- Partials      703      704       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants