Skip to content

Added activeDeadlineSeconds for Kubernetes Job Resource Management Description: #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

Ekam219
Copy link

@Ekam219 Ekam219 commented Mar 31, 2025

@DonggeLiu
This pull request addresses an issue in the pr-exp.yaml file, where the second Kubernetes job was missing the activeDeadlineSeconds field. The absence of this field could have caused the job to run indefinitely, consuming excessive resources and leading to unpredictable behavior. This fix ensures that both jobs have the same resource management strategy.

Changes:
Added activeDeadlineSeconds: 43200 (12 hours) to the second Kubernetes job configuration. This prevents the job from running indefinitely and reduces resource consumption.

Fix:
By adding this field, we align the second job’s configuration with the first job, which already has a similar field, ensuring consistent resource management across both jobs.

Additional Notes:
The change aims to prevent excessive resource consumption by limiting the runtime of the job to 12 hours. This is a more reasonable timeframe compared to the original 7 days, ensuring better resource allocation for quicker jobs.
#931

@DonggeLiu DonggeLiu changed the base branch from main to DonggeLiu-patch-1 April 8, 2025 07:03
@DonggeLiu
Copy link
Collaborator

DonggeLiu commented Apr 8, 2025

Thanks @Ekam219.
I will merge this to an experiment PR (#973) so that we can double-check it before merging into main.

@DonggeLiu DonggeLiu merged commit f1912b7 into google:DonggeLiu-patch-1 Apr 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants