Skip to content

Conversation

CydeWeys
Copy link
Member

@CydeWeys CydeWeys commented Sep 19, 2025

This change is Reviewable

@CydeWeys CydeWeys requested a review from jicelhay September 19, 2025 18:41
Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


core/src/main/java/google/registry/idn/Latin-IDN.xml line 43 at r1 (raw file):

  <p><code>&lt;scope type=&quot;domain&quot;&gt;</code>[Please provide, in &quot;.domain&quot; format]<code>&lt;/scope&gt;</code></p>
<p><strong>Registry Contact Information:</strong></p>
  <p>Please fill in the <a href="#registry_contact_details">Registry Contact Details</a>.</p>

Fill Registry Contact Details.

Copy link
Member Author

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jicelhay)


core/src/main/java/google/registry/idn/Latin-IDN.xml line 43 at r1 (raw file):

Previously, jicelhay (Juan Celhay) wrote…

Fill Registry Contact Details.

I did? See section <h2>Registry Contact Details</h2> below.

Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jicelhay reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys)


core/src/main/java/google/registry/idn/Latin-IDN.xml line 43 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

I did? See section <h2>Registry Contact Details</h2> below.

Ok, the wording of the instructions is kind of confusing but since it's linked LGTM

Copy link
Collaborator

@jicelhay jicelhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)

@CydeWeys CydeWeys enabled auto-merge September 19, 2025 19:47
@CydeWeys CydeWeys added this pull request to the merge queue Sep 24, 2025
Merged via the queue into google:master with commit d3c6de7 Sep 24, 2025
9 checks passed
@CydeWeys CydeWeys deleted the latin-table-unconfusable branch September 24, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants