Skip to content

Commit

Permalink
Update cloudbuild-release.yaml with nokeycheck option (#2431)
Browse files Browse the repository at this point in the history
  • Loading branch information
ptkach authored May 6, 2024
1 parent 49d2e34 commit 2c7bf2c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions release/cloudbuild-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ steps:
$(gcloud auth list --format='get(account)' --filter=active)
git add .
git commit -m "Release commit for tag ${TAG_NAME}"
git push origin master
git push -o nokeycheck origin master

This comment has been minimized.

Copy link
@CydeWeys

CydeWeys May 7, 2024

Member

I'm not sure turning this off is a good long-term solution? Seems better to me to eliminate the false positive in that one file through whatever mechanism and then continue to have key check protection going forward?

This comment has been minimized.

Copy link
@ptkach

ptkach May 7, 2024

Author Collaborator

At first I fixed the formatting in PR - #2430
It was proposed to eliminate the check instead in that PR

git tag ${TAG_NAME}
git push origin ${TAG_NAME}
git push -o nokeycheck origin ${TAG_NAME}
timeout: 3600s
options:
machineType: 'E2_HIGHCPU_32'

0 comments on commit 2c7bf2c

Please sign in to comment.