-
Notifications
You must be signed in to change notification settings - Fork 274
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update cloudbuild-release.yaml with nokeycheck option (#2431)
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,9 +210,9 @@ steps: | |
$(gcloud auth list --format='get(account)' --filter=active) | ||
git add . | ||
git commit -m "Release commit for tag ${TAG_NAME}" | ||
git push origin master | ||
git push -o nokeycheck origin master | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ptkach
Author
Collaborator
|
||
git tag ${TAG_NAME} | ||
git push origin ${TAG_NAME} | ||
git push -o nokeycheck origin ${TAG_NAME} | ||
timeout: 3600s | ||
options: | ||
machineType: 'E2_HIGHCPU_32' |
I'm not sure turning this off is a good long-term solution? Seems better to me to eliminate the false positive in that one file through whatever mechanism and then continue to have key check protection going forward?