Add Total Variation (TV) to metrax #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolved issues with latest commit @jshin1394! |
|
Also, I'm not sure if this is just on my machine (WSL, Ryzen 7 3800H, RTX 3070 Mobile) but some tests tests_psnr... and tests_ssim... and more seem to be failing for me. I reverted to ~HEAD and still found them failing. Should I make an issue about this? |
Yes please file an issue. Could you also include the test output as well when filing the issue so it'll help us debug? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue #63]
Add total variation as defined by here: Tensorflow Total Variation
Add tests comparing results against Tensorflow