feat: a read-optimized FactStore #66
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, regarding the issue: #65
I have studied about FactStore and implemented a semi-columnar storage for better reads in big queries. Write still needs optimizations and I'm thinking of it as of now. You can run the benchmarking tests in benchmark_test.go in factstore package. @burakemir I'm not sure if you meant I shouldn't have used maps or not but this is the benchmark so far. I'd appreciate if you could guide me through.