Keep ia0 as owner of rust Changelogs #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `*.md` rule for documentation is a bit strong. The intent was only to capture READMEs under rust, so this PR explicitly excludes the CHANGELOGs from that rule. This makes it possible to do pure code changes to the Rust CLI and library without double approvals.
|
See #1167 for an example PR requiring double approvals. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly reassigns ownership of the Rust CHANGELOG.md files. The new rule in the .github/CODEOWNERS file is specific and correctly placed to override the more general *.md rule, achieving the stated goal. The change is simple and effective. Based on the context in the pull request description, the *.md rule seems overly broad. It might be beneficial to create a follow-up pull request to narrow down that rule to its intended scope (e.g., **/README.md) to prevent similar ownership issues in the future.
invernizzi
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
*.mdrule for documentation is a bit strong. The intent was only to capture READMEs under rust, so this PR explicitly excludes the CHANGELOGs from that rule. This makes it possible to do pure code changes to the Rust CLI and library without double approvals.