Add support for rejecting invalid inputs #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Hi @KanishAnand this seems like an important fix, thanks for your work on the topic! 👍 Personally I believe one of the two approaches being implemented simultaneously here — the build system version — makes things overly complex and "magic" without a strong enough return in value: One way, the new macro way, seems enough. So my vote would be to drop the everything LIBPROTOBUFMUTATOR_ENABLE_RETURN_CODE from the pull request but ideally after @vitalybuka has confirmed buy-in in the pull request in general and this very direction too, so that you don't waste your time. PS: I'm not a maintainer here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to reject storing invalid inputs in corpus. There is an ongoing discussion about how to support this while preserving backward compatibility.
This PR adds two ways to reject invalid inputs:
LIBPROTOBUFMUTATOR_ENABLE_RETURN_CODEvia the build system or#defineing it before includinglibfuzzer_macro.h.DEFINE_PROTO_FUZZER_RETmacro instead ofDEFINE_PROTO_FUZZER.