Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send email when new passlist entry is added #2087

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Send email when new passlist entry is added #2087

wants to merge 32 commits into from

Conversation

rfontanarosa
Copy link
Collaborator

@rfontanarosa rfontanarosa commented Nov 12, 2024 •
edited
Loading

closes #2077

Screenshot 2024-12-11 alle 15 58 55

@rfontanarosa rfontanarosa changed the title Rfontanarosa/2077/feature user access granted notification Email notification when new passlist entry is added Nov 12, 2024
@gino-m gino-m changed the title Email notification when new passlist entry is added Send email when new passlist entry is added Nov 17, 2024
@rfontanarosa rfontanarosa self-assigned this Nov 29, 2024
@gino-m
Copy link
Collaborator

gino-m commented Dec 10, 2024

@rfontanarosa Any updates on this PR?

@rfontanarosa rfontanarosa requested a review from gino-m December 11, 2024 15:02
@rfontanarosa rfontanarosa marked this pull request as ready for review December 11, 2024 15:02
gino-m
gino-m requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

functions/src/common/context.ts Outdated Show resolved Hide resolved
functions/src/common/context.ts Outdated Show resolved Hide resolved
functions/src/common/context.ts Outdated Show resolved Hide resolved
functions/src/common/datastore.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/utils.ts Show resolved Hide resolved
functions/src/on-create-passlist-entry.ts Outdated Show resolved Hide resolved
@rfontanarosa rfontanarosa requested a review from gino-m December 13, 2024 15:07
gino-m
gino-m requested changes Dec 13, 2024
View reviewed changes
functions/src/common/mail-service.ts Show resolved Hide resolved
functions/src/common/mail-service.ts Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/common/mail-service.ts Outdated Show resolved Hide resolved
functions/src/on-create-passlist-entry.ts Show resolved Hide resolved
functions/src/on-create-passlist-entry.ts Outdated Show resolved Hide resolved
@rfontanarosa rfontanarosa requested a review from gino-m December 16, 2024 14:14
gino-m
gino-m requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since this will be used in production can you also add tests, at least for the two main base cases (email sent when mail server config set, and nothing happens when mail server config missing)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@rfontanarosa rfontanarosa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Auth] Send an email to user when added to passlist
2 participants
@rfontanarosa @gino-m