Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to task proto serialization #1923

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

sufyanAbbasi
Copy link
Contributor

@sufyanAbbasi sufyanAbbasi commented Jul 19, 2024

Fixes #1911
Fixes #1922
Fixes #1921

Ensures that tasks are properly serialized to proto and are updated on task creation step.

  • Calls updateJob() on addOrUpdateTask() routine to ensure that we serialize the task proto at the right time.
  • Added a task list parameter override to account for the job's tasks list to be readonly
  • Supports arrays when serializing task list into proto
  • Don't serialize task protos in survey > job > tasks, since we are parsing them from /jobs instead.
  • Fixed issue with swapped LOI_METADATA and LOI_DATA fields.
  • Fixed issue with minAccuracyMeters set to null instead of a default value --> gets optimized out.
  • Tested on local web server

@sufyanAbbasi sufyanAbbasi marked this pull request as ready for review July 23, 2024 22:51
@rfontanarosa rfontanarosa merged commit 8d34211 into master Jul 24, 2024
5 checks passed
@rfontanarosa rfontanarosa deleted the sufy/1911/task-proto branch July 24, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants