readability improvements

google · Dec 28, 2024 · 90fbc04 · 90fbc04
1 parent 7d7acec
commit 90fbc04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/functions/src/common/datastore.ts b/functions/src/common/datastore.ts
@@ -174,9 +174,9 @@ export class Datastore {
     );
     return leftOuterJoinSorted(
       loisIterator,
-      v1 => v1.get(l.id),
+      loiDoc => loiDoc.get(l.id),
       submissionsIterator,
-      v2 => v2.get(sb.loiId)
+      submissionDoc => submissionDoc.get(sb.loiId)
     );
   }
 

diff --git a/functions/src/export-csv.ts b/functions/src/export-csv.ts
@@ -51,8 +51,7 @@ export async function exportCsvHandler(
     res.status(HttpStatus.FORBIDDEN).send('Permission denied');
     return;
   }
-  const canManageSurvey = canImport(user, surveyDoc);
-  const ownerId = !canManageSurvey ? userId : undefined;
+  const ownerId = canImport(user, surveyDoc) ? undefined : userId;
 
   console.log(
     `Exporting survey '${surveyId}', job '${jobId}', owner '${