Skip to content

Allow substring matching in nnx.PathContains #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow substring matching in nnx.PathContains #5094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d34055
allow substring matching
thijs-vanweezel Nov 17, 2025
12b2e42
test pathcontains with exact=false
thijs-vanweezel Nov 18, 2025
a7bb109
hint that key is cast to string
thijs-vanweezel Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions flax/nnx/filterlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,16 @@ def __repr__(self):

@dataclasses.dataclass(frozen=True)
class PathContains:
key: Key
key: Key | str
exact: bool = True

def __call__(self, path: PathParts, x: tp.Any):
return self.key in path
if self.exact:
return self.key in path
return any(str(self.key) in str(part) for part in path)

def __repr__(self):
return f'PathContains({self.key!r})'
return f'PathContains({self.key!r}, exact={self.exact})'


class PathIn:
Expand Down
7 changes: 6 additions & 1 deletion tests/nnx/filters_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,20 @@ class TestFilters(absltest.TestCase):
def test_path_contains(self):
class Model(nnx.Module):
def __init__(self, rngs):
self.backbone = nnx.Linear(2, 3, rngs=rngs)
self.backbone1 = nnx.Linear(2, 3, rngs=rngs)
self.backbone2 = nnx.Linear(3, 3, rngs=rngs)
self.head = nnx.Linear(3, 10, rngs=rngs)

model = Model(nnx.Rngs(0))

head_state = nnx.state(model, nnx.PathContains('head'))
backbones_state = nnx.state(model, nnx.PathContains('backbone', exact=False))

self.assertIn('head', head_state)
self.assertNotIn('backbone', head_state)
self.assertIn('backbone1', backbones_state)
self.assertIn('backbone2', backbones_state)
self.assertNotIn('head', backbones_state)

if __name__ == '__main__':
absltest.main()
Loading