Move ArrayRef creation to the end of Variable creation
#4980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Sep 24, 2025
| _value = value | ||
|
|
||
| object.__setattr__(self, 'raw_value', _value) | ||
| object.__setattr__(self, 'raw_value', value) |
There was a problem hiding this comment.
With this change we shouldn't allow Ref's to be passed as an input, can we raise if is_array_ref(value) here and then maybe remove the same check bellow?
There was a problem hiding this comment.
Discussed offline and we concluded each variable should own its own array/ref and don't allow sharing.
Implemented and changed mutable_array_test to reflect it.
cgarciae
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to make sharding changes to the underlying array before passing it around by reference.