Minor improvements of lm1b_nnx example #4745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
commented
May 13, 2025
| @@ -48,9 +48,11 @@ def _get_datasets(self): | |||
| vocab_path = os.path.join(tempfile.mkdtemp(), 'sentencepiece_model') | |||
|
|
|||
| # Go two directories up to the root of the flax directory. | |||
| flax_root_dir = pathlib.Path(__file__).parents[4] | |||
| try: | |||
| flax_root_dir = pathlib.Path(__file__).parents[4] | |||
There was a problem hiding this comment.
If __file__ is /flax/examples/lm1b_nnx then parents[4] raises IndexError
| @@ -34,7 +34,7 @@ | |||
| 'File path to the training hyperparameter configuration.', | |||
| lock_config=True, | |||
| ) | |||
| flags.mark_flags_as_required(['config', 'workdir']) | |||
| flags.mark_flags_as_required(['workdir']) | |||
There was a problem hiding this comment.
This fixes a warning saying that config flag has a default value so it can't be strictly required.
vfdev-5
force-pushed
the
fix-lm1b-nnx-example
branch
from
1e1980a to
c00f173
Compare
vfdev-5
commented
May 14, 2025
| @@ -75,9 +75,9 @@ tensorboard --logdir=$HOME/logs | |||
| You should expect to get numbers similar to these: | |||
|
|
|||
|
|
|||
| Hardware | config | Training time | Loss | TensorBoard.dev | Workdir | |||
There was a problem hiding this comment.
Removed tensorboard.dev link as not usable
vfdev-5
force-pushed
the
fix-lm1b-nnx-example
branch
3 times, most recently
from
16677b3 to
84d82fb
Compare
vfdev-5
changed the title
cgarciae
approved these changes
May 15, 2025
|
Thanks @vfdev-5 ! |
vfdev-5
force-pushed
the
fix-lm1b-nnx-example
branch
from
84d82fb to
92caa5f
Compare
vfdev-5
force-pushed
the
fix-lm1b-nnx-example
branch
from
92caa5f to
7def227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from flax import linen as nnand usage of linenTraining logs on 2 GPUs: https://gist.github.com/vfdev-5/f75a2e32d231d892a6eee6cb1a451aa5