Repository navigation
Regenerate 64-bit embedded schema header to fix Windows CI - #9435
Open
rustyconover wants to merge 1 commit into
Open
rustyconover wants to merge 1 commit into
rustyconover wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows generated-code check fails immediately after the CMake build because
flatcregeneratestests/64bit/test_64bit_bfbs_generated.hwithalignas(uint64_t), added by #9425, while the checked-in header still lacks it. Regenerate that header using the flags inCMakeLists.txt. Only the array declaration changes; the schema bytes are unchanged.This complements #9434, which updates
tests/monster_test_bfbs_generated.h. Its Windows job shows this exact remaining diff.scripts/generate_code.pydoes not generate the 64-bit header, so it needs regeneration through the CMake command. Found while investigating #9414; the same failure occurs on master.Validation on macOS arm64: regenerated with the CMake flags and confirmed a one-line diff;
git diff --checkpasses. With both header updates applied locally, the generated-code and gRPC checks, C++flattests, andtests/GoTest.shall pass. Windows execution remains for CI. The independent Swift dependency failure is tracked by #9412.