Improve Rust flatbuffers crate #8572
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes several bugs and adds support for missing features to the flatbuffers and flatbuffers_reflection crates. * fixes google#8550 * fixes google#8548 * adds reflection support for vectors of values of unknown type * adds verification support for vectors of unions * makes the unsafe get_field_* functions infallible as their success is implied by the unsafe precondition * adds the unsafe function Vector::cast() for casting between vector types * exposes get_type_size() * adds Struct::bytes() to get a slice to a byte buffer which starts with the struct value
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
[Rust] Allow verification of buffers from specified table
[Rust] Allow reflection verifier to start with custom root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs and adds support for missing features to the
flatbuffersandflatbuffers_reflectioncrates.get_field_vector()only works for vectors of primitive types #8550get_field_*functions infallible as their success is implied by the unsafe preconditionVector::cast()for casting between vector typesget_type_size()Struct::bytes()to get a slice to a byte buffer which starts with the struct value