vk: refactor utils into its own namespace #8280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move the code that was contained within two "utils" files into separate utils sources in the vulkan/utils directory.
pixelflinger
requested changes
Dec 5, 2024
|
|
||
| namespace filament::backend { | ||
| namespace filament::backend::fvkutils { |
There was a problem hiding this comment.
why didn't you use utils? is it because it becomes ambiguous with filament::utils?
why the f? what about just vkutils?
There was a problem hiding this comment.
The fvk stands for "Filament Vulkan". I already use FVK_ for various constants to distinguish it from VK_ constants in the vk API. I also didn't want to introduce a filament::backend::utils since that seems like something that's something shared across backends.
bejado
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move the code that was contained within two "utils" files into separate utils sources in the vulkan/utils directory.