Skip to content

Added suppressions for type errors in various places. #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added suppressions for type errors in various places. #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fiddle/_src/codegen/import_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def _compatible_with_existing(self, stmt: AnyImport) -> bool:
for node in self.imports_by_full_name.values():
if get_namespace_name(node) == namespace_name:
return get_full_module_name(node).split(".")[0] == base_module_name
return None
return None # pytype: disable=bad-return-type

def add_by_name(self, full_module_name: str) -> str:
"""Adds an import given a module name.
Expand Down
2 changes: 1 addition & 1 deletion fiddle/_src/experimental/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def allows_value(self, value: Any) -> bool:

Args:
value: An imported value.
"""
""" # pytype: disable=bad-return-type


class PyrefPolicyError(Exception):
Expand Down
Loading