Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add a timeout knob to control stackdriver exporter behavior. #999

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Sep 16, 2020

The default timeout is 5s.

Works towards google/exposure-notifications-verification-server#474

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 16, 2020
@google-oss-robot google-oss-robot added the size/XS Auto: extra small number of changes. label Sep 16, 2020
@icco
Copy link
Contributor

icco commented Sep 16, 2020

/assign

@google-oss-robot google-oss-robot added lgtm Auto: added by prown with a reviewer LGTMs approved Auto: added by prow when enough reviewers approve. labels Sep 16, 2020
@yegle
Copy link
Contributor Author

yegle commented Sep 16, 2020

/retest

1 similar comment
@chaodaiG
Copy link
Contributor

/retest

@google-oss-robot google-oss-robot removed the lgtm Auto: added by prown with a reviewer LGTMs label Sep 16, 2020
Copy link
Contributor

@icco icco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Sep 17, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, mikehelmick, yegle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b4f95b7 into google:main Sep 17, 2020
@yegle yegle deleted the add-timeout-knob branch September 22, 2020 16:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/XS Auto: extra small number of changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants