This repository was archived by the owner on Jul 12, 2023. It is now read-only.
Making stackdriver exporter options configurable in env var #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variable. This allows me to fine-tuning these values and see if adjusting the value can eliminate google/exposure-notifications-verification-server#474 The value used should be backward compatible. The value for BundleDelayThreshold/BundleCountThreshold is from https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/blob/db101e30979316cca594a74b3181a9a3b6094086/trace.go#L72-L81
google-cla
bot
added
the
cla: yes
yegle
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
sethvargo
reviewed
Sep 15, 2020
google-oss-robot
added
lgtm
mikehelmick
approved these changes
Sep 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo, yegle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to fine-tuning these values and see if adjusting the
value can eliminate
google/exposure-notifications-verification-server#474
The value used should be backward compatible. The value for
BundleDelayThreshold/BundleCountThreshold is from
https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/blob/db101e30979316cca594a74b3181a9a3b6094086/trace.go#L72-L81
Release Note