Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Fix the metric missing issue caused by repeated metric point upload. #1039

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Sep 29, 2020

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 29, 2020
@google-oss-robot google-oss-robot added the size/XS Auto: extra small number of changes. label Sep 29, 2020
Copy link
Contributor

@icco icco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

omg. If this works, you're the truest of all heros.

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Sep 29, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, yegle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot added the approved Auto: added by prow when enough reviewers approve. label Sep 29, 2020
@google-oss-robot google-oss-robot merged commit fa553f3 into google:main Sep 29, 2020
@sethvargo
Copy link
Member

For the record, even if it doesn't work, I still think you're a hero 🦸‍♂️

@yegle yegle deleted the fix-metric-missing branch September 29, 2020 06:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/XS Auto: extra small number of changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants