Skip to content

Conversation

@TonyWu1995
Copy link

issue #2045

Before:

image

After:

image

image

Copy link
Contributor

@fekete-robert fekete-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Contributor

@huanlin huanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
@chalin chalin added the enhancement New feature or request label Aug 5, 2024
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fekete-robert @deining @TonyWu1995 - won't this break if there is no .LinkTitle? Have you tested this scenario?

@TonyWu1995
Copy link
Author

@fekete-robert @deining @TonyWu1995 - won't this break if there is no .LinkTitle? Have you tested this scenario?

The LinkTitle method returns the linkTitle field as defined in front matter, falling back to the value returned by the Title method. --from: LinkTitle

If there is no linktitle, the tag will be like this:

image

because the frontmatter is defined like this:

---
title: Artificial Intelligence
--- 

@chalin chalin modified the milestones: 24Q3, 24Q4 Oct 3, 2024
@chalin chalin modified the milestones: 24Q4, 25Q1 Jan 7, 2025
@chalin chalin removed this from the 25Q1 milestone May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants